fix(project-onboard): use correct brain_path key in Phase 1#27
Merged
fix(project-onboard): use correct brain_path key in Phase 1#27
Conversation
Phase 1 told agents to look for `$PBRAIN_BRAIN_ROOT` and the `brain_root` key in `~/.pbrain/config.json`, but `pbrain init` writes `brain_path` (env var `$PBRAIN_BRAIN_PATH`). The config-file lookup always missed on correctly initialized installs, forcing every invocation to fall through to the filesystem scan or user prompt. Replace with the real key/env var, add a concrete `jq` command so agents don't invent parsing logic, and leave an explicit "do NOT look for brain_root" note to prevent regression from stale docs in training data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
project-onboardwas looking for$PBRAIN_BRAIN_ROOTand thebrain_rootkey in~/.pbrain/config.json, butpbrain initwritesbrain_path(env var$PBRAIN_BRAIN_PATH). The config-file lookup always missed on correctly-initialized installs, so the skill fell through to the filesystem scan or user prompt every time.jqcommand so agents don't invent parsing logic, and leave an explicit "do NOT look forbrain_root" guardrail to prevent regression from stale docs.Test plan
grep -r "brain_root\|PBRAIN_BRAIN_ROOT" skills/returns only the intentional guardrail commentbun test test/skills-conformance.test.ts test/resolver.test.ts→ 140/140 passproject-onboardin a repo and confirm Phase 1 resolves via the config-file path instead of falling through to the filesystem scan